Alien Nathan Edward

Solitary, poor, nasty, brutish and short

  • 0 Posts
  • 24 Comments
Joined 1 year ago
cake
Cake day: July 4th, 2023

help-circle






  • okay but land ownership and rent seeking are inherent, inevitable parts of capitalism. Even Smith talked about how rent-seeking is an unavoidable outcome of a system where one person can own what another needs, and about how in order to succeed capitalism will require some way of discouraging or taxing rent-seeking. “As soon as the land of any country has all become private property, the landlords, like all other men, love to reap where they never sowed and demand a rent even for its natural produce.” This isn’t a new phenomenon and it’s not a return to pre-capitalism, it’s capitalism doing what we all new it was going to do from the beginning.










  • this function returns -2 as success and -1 as error

    Thats exactly the kind of thing I’m talking about when I say to prioritize refactoring over comments. If you own the system returning the error code, drag it out of the 1970s and have it return an error object with some actual information in it instead. If you don’t own the system, wrap the error code in an enum that adds syntactic meaning or do a map of integer and exception and then return the mapped exception. The very last resort, after you’ve tried everything else, should be

    return -1; //-1 indicates success


  • I agree with your team lead wholeheartedly, but not for the reasons he would tell you. Comments should be used when code is too complex for the “name your variables nouns and your methods verbs” convention doesn’t communicate what the code does in a narrative fashion. Thing is, that level of complexity is definitely a code smell. You seem to be saying that clarifying comments are the solution, he seems to think that you should be able to rename vars and methods until the meaning is clear, and Im offering a third way: figure out why the fuck the code is doing something hard to understand and maybe try to unfuck it, then resort to comments if and only if that’s not possible. Remember that a code smell isn’t necessarily something that needs to be removed, it’s just a flag that says “let’s make double damn sure there isn’t a better way to do this before we do it this way”.